Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Highlights #1059

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Onboarding Highlights #1059

merged 5 commits into from
Oct 28, 2024

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Sep 16, 2024

Asana: https://app.asana.com/0/1206594217596623/1208204606544051/f

Onboarding Highlights flow for Mac and Windows

Figma
Prototype

Previews:

@mgurgel mgurgel marked this pull request as draft September 16, 2024 14:40
@mgurgel mgurgel self-assigned this Sep 16, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 20, 2024
@mgurgel mgurgel marked this pull request as ready for review September 20, 2024 16:40
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 26, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 27, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 27, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 27, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 27, 2024
Copy link

github-actions bot commented Oct 4, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@duckduckgo duckduckgo deleted a comment from github-actions bot Oct 10, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Oct 10, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Oct 10, 2024
@mgurgel mgurgel force-pushed the mgurgel/onboarding-highlights branch 5 times, most recently from 0711d3b to d4e0a25 Compare October 15, 2024 18:29
@mgurgel mgurgel force-pushed the mgurgel/onboarding-highlights branch 2 times, most recently from 50fda72 to 3c364e5 Compare October 17, 2024 11:19
Copy link

github-actions bot commented Oct 17, 2024

[Beta] Generated file diff

Time updated: Mon, 28 Oct 2024 10:02:26 GMT

Integration
    - integration/pages/onboarding/js/index.css
  • integration/pages/onboarding/js/index.js
  • integration/pages/onboarding/js/inline.js
  • integration/pages/onboarding/locales/de/onboarding.json
  • integration/pages/onboarding/locales/en/onboarding.json
  • integration/pages/onboarding/locales/es/onboarding.json
  • integration/pages/onboarding/locales/fr/onboarding.json
  • integration/pages/onboarding/locales/it/onboarding.json
  • integration/pages/onboarding/locales/nl/onboarding.json
  • integration/pages/onboarding/locales/pl/onboarding.json
  • integration/pages/onboarding/locales/pt/onboarding.json
  • integration/pages/onboarding/locales/ru/onboarding.json

File has changed

Windows
    - windows/pages/onboarding/js/index.css
  • windows/pages/onboarding/js/index.js
  • windows/pages/onboarding/js/inline.js
  • windows/pages/onboarding/locales/de/onboarding.json
  • windows/pages/onboarding/locales/en/onboarding.json
  • windows/pages/onboarding/locales/es/onboarding.json
  • windows/pages/onboarding/locales/fr/onboarding.json
  • windows/pages/onboarding/locales/it/onboarding.json
  • windows/pages/onboarding/locales/nl/onboarding.json
  • windows/pages/onboarding/locales/pl/onboarding.json
  • windows/pages/onboarding/locales/pt/onboarding.json
  • windows/pages/onboarding/locales/ru/onboarding.json

File has changed

Apple
    - dist/pages/onboarding/js/index.css
  • dist/pages/onboarding/js/index.js
  • dist/pages/onboarding/js/inline.js
  • dist/pages/onboarding/locales/de/onboarding.json
  • dist/pages/onboarding/locales/en/onboarding.json
  • dist/pages/onboarding/locales/es/onboarding.json
  • dist/pages/onboarding/locales/fr/onboarding.json
  • dist/pages/onboarding/locales/it/onboarding.json
  • dist/pages/onboarding/locales/nl/onboarding.json
  • dist/pages/onboarding/locales/pl/onboarding.json
  • dist/pages/onboarding/locales/pt/onboarding.json
  • dist/pages/onboarding/locales/ru/onboarding.json

File has changed

New Files
    - integration/pages/onboarding/assets/img/background-dark-v3.jpg
  • integration/pages/onboarding/assets/img/background-v3.jpg
  • integration/pages/onboarding/assets/img/hiker.svg
  • integration/pages/onboarding/assets/img/icons/check-24.svg
  • integration/pages/onboarding/assets/img/icons/chrome.svg
  • integration/pages/onboarding/assets/img/icons/cross-24.svg
  • integration/pages/onboarding/assets/img/icons/ddg.svg
  • integration/pages/onboarding/assets/img/icons/safari.svg
  • integration/pages/onboarding/assets/img/icons/stop-24.svg
  • integration/pages/onboarding/assets/img/steps/v3/ads.svg
  • integration/pages/onboarding/assets/img/steps/v3/cookie.svg
  • integration/pages/onboarding/assets/img/steps/v3/default-browser.svg
  • integration/pages/onboarding/assets/img/steps/v3/dock.svg
  • integration/pages/onboarding/assets/img/steps/v3/favorite.svg
  • integration/pages/onboarding/assets/img/steps/v3/fire.svg
  • integration/pages/onboarding/assets/img/steps/v3/home.svg
  • integration/pages/onboarding/assets/img/steps/v3/import.svg
  • integration/pages/onboarding/assets/img/steps/v3/search.svg
  • integration/pages/onboarding/assets/img/steps/v3/session-restore.svg
  • integration/pages/onboarding/assets/img/steps/v3/shield.svg
  • integration/pages/onboarding/assets/img/steps/v3/video-player.svg
  • integration/pages/onboarding/js/background-dark-v3-SVG27AYV.jpg
  • integration/pages/onboarding/js/background-v3-ZJJEKZRE.jpg
  • integration/pages/onboarding/js/check-24-TKI2L77Y.svg
  • integration/pages/onboarding/js/chrome-CN5U36NT.svg
  • integration/pages/onboarding/js/cross-24-LC5CE255.svg
  • integration/pages/onboarding/js/ddg-VAGQ4AK4.svg
  • integration/pages/onboarding/js/safari-HDKLSKMI.svg
  • integration/pages/onboarding/js/stop-24-RHIE2TQT.svg
  • windows/pages/onboarding/assets/img/background-dark-v3.jpg
  • windows/pages/onboarding/assets/img/background-v3.jpg
  • windows/pages/onboarding/assets/img/hiker.svg
  • windows/pages/onboarding/assets/img/icons/check-24.svg
  • windows/pages/onboarding/assets/img/icons/chrome.svg
  • windows/pages/onboarding/assets/img/icons/cross-24.svg
  • windows/pages/onboarding/assets/img/icons/ddg.svg
  • windows/pages/onboarding/assets/img/icons/safari.svg
  • windows/pages/onboarding/assets/img/icons/stop-24.svg
  • windows/pages/onboarding/assets/img/steps/v3/ads.svg
  • windows/pages/onboarding/assets/img/steps/v3/cookie.svg
  • windows/pages/onboarding/assets/img/steps/v3/default-browser.svg
  • windows/pages/onboarding/assets/img/steps/v3/dock.svg
  • windows/pages/onboarding/assets/img/steps/v3/favorite.svg
  • windows/pages/onboarding/assets/img/steps/v3/fire.svg
  • windows/pages/onboarding/assets/img/steps/v3/home.svg
  • windows/pages/onboarding/assets/img/steps/v3/import.svg
  • windows/pages/onboarding/assets/img/steps/v3/search.svg
  • windows/pages/onboarding/assets/img/steps/v3/session-restore.svg
  • windows/pages/onboarding/assets/img/steps/v3/shield.svg
  • windows/pages/onboarding/assets/img/steps/v3/video-player.svg
  • windows/pages/onboarding/js/background-dark-v3-SVG27AYV.jpg
  • windows/pages/onboarding/js/background-v3-ZJJEKZRE.jpg
  • windows/pages/onboarding/js/check-24-TKI2L77Y.svg
  • windows/pages/onboarding/js/chrome-CN5U36NT.svg
  • windows/pages/onboarding/js/cross-24-LC5CE255.svg
  • windows/pages/onboarding/js/ddg-VAGQ4AK4.svg
  • windows/pages/onboarding/js/safari-HDKLSKMI.svg
  • windows/pages/onboarding/js/stop-24-RHIE2TQT.svg
  • dist/pages/onboarding/assets/img/background-dark-v3.jpg
  • dist/pages/onboarding/assets/img/background-v3.jpg
  • dist/pages/onboarding/assets/img/hiker.svg
  • dist/pages/onboarding/assets/img/icons/check-24.svg
  • dist/pages/onboarding/assets/img/icons/chrome.svg
  • dist/pages/onboarding/assets/img/icons/cross-24.svg
  • dist/pages/onboarding/assets/img/icons/ddg.svg
  • dist/pages/onboarding/assets/img/icons/safari.svg
  • dist/pages/onboarding/assets/img/icons/stop-24.svg
  • dist/pages/onboarding/assets/img/steps/v3/ads.svg
  • dist/pages/onboarding/assets/img/steps/v3/cookie.svg
  • dist/pages/onboarding/assets/img/steps/v3/default-browser.svg
  • dist/pages/onboarding/assets/img/steps/v3/dock.svg
  • dist/pages/onboarding/assets/img/steps/v3/favorite.svg
  • dist/pages/onboarding/assets/img/steps/v3/fire.svg
  • dist/pages/onboarding/assets/img/steps/v3/home.svg
  • dist/pages/onboarding/assets/img/steps/v3/import.svg
  • dist/pages/onboarding/assets/img/steps/v3/search.svg
  • dist/pages/onboarding/assets/img/steps/v3/session-restore.svg
  • dist/pages/onboarding/assets/img/steps/v3/shield.svg
  • dist/pages/onboarding/assets/img/steps/v3/video-player.svg
  • dist/pages/onboarding/js/background-dark-v3-SVG27AYV.jpg
  • dist/pages/onboarding/js/background-v3-ZJJEKZRE.jpg
  • dist/pages/onboarding/js/check-24-TKI2L77Y.svg
  • dist/pages/onboarding/js/chrome-CN5U36NT.svg
  • dist/pages/onboarding/js/cross-24-LC5CE255.svg
  • dist/pages/onboarding/js/ddg-VAGQ4AK4.svg
  • dist/pages/onboarding/js/safari-HDKLSKMI.svg
  • dist/pages/onboarding/js/stop-24-RHIE2TQT.svg

❌ File only exists in new changeset

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 91dbe8c
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/671f60f6c1596a0008d46927
😎 Deploy Preview https://deploy-preview-1059--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mgurgel mgurgel force-pushed the mgurgel/onboarding-highlights branch from 00d75ef to 30abc13 Compare October 18, 2024 11:08
@mgurgel mgurgel changed the title [WIP] Onboarding Highlights Onboarding Highlights Oct 18, 2024
@duckduckgo duckduckgo deleted a comment from netlify bot Oct 18, 2024
@mgurgel mgurgel force-pushed the mgurgel/onboarding-highlights branch from ca81b56 to e9f5f95 Compare October 18, 2024 13:13
@mgurgel mgurgel requested a review from a team as a code owner October 21, 2024 08:56
@mgurgel mgurgel force-pushed the mgurgel/onboarding-highlights branch 7 times, most recently from 8d5147b to f29f1da Compare October 24, 2024 09:42
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested extensively for weeks with different teams.

I also validated that this new work does not impact the existing flows on windows (v1+v2)

@mgurgel mgurgel requested a review from shakyShane October 28, 2024 09:58
@mgurgel mgurgel force-pushed the mgurgel/onboarding-highlights branch from 0322289 to 91dbe8c Compare October 28, 2024 10:01
@mgurgel mgurgel merged commit 360983f into main Oct 28, 2024
12 checks passed
@mgurgel mgurgel deleted the mgurgel/onboarding-highlights branch October 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants