Malicious Site Protection - Make clientSideHit optional parameter #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallexxx
reviewed
Jan 30, 2025
| private func fireErrorPageShown(threatKind: ThreatKind, clientSideHit: Bool) async { | ||
| let filterSet = await dataManager.dataSet(for: .filterSet(threatKind: threatKind)) | ||
| // https://app.asana.com/0/0/1209113403594297/1209141231997704/f | ||
| let sanitisedClientSideHit = filterSet.filters.count < 100 ? clientSideHit : nil |
There was a problem hiding this comment.
it seems the Send Pixel clientSideHit parameter only if filterSet size is greater than 100 condition is inverted here
Also please add this as a comment in addition to the asana task URL for clarity
There was a problem hiding this comment.
🤦 good catch! I also updated the comment
mallexxx
approved these changes
Jan 30, 2025
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-ios
branch
from
33c141b to
e3520f7
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-pixels-client-side-hit-param
branch
from
407ba36 to
40910c9
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-pixels-client-side-hit-param
branch
from
d3a3e39 to
0e76b07
Compare
alessandroboron
merged commit 02091ea
into
alessandro/malicious-site-protection-ios
7 checks passed
alessandroboron
deleted the
alessandro/malicious-site-protection-pixels-client-side-hit-param
branch
alessandroboron
added a commit
that referenced
this pull request
Feb 4, 2025
) **Required**: Task/Issue URL: https://app.asana.com/0/1206329551987282/1209242004458518/f iOS PR: duckduckgo/iOS#3891 macOS PR: duckduckgo/macos-browser#3796 What kind of version bump will this require?: Minor **Description**: This PR makes `MaliciousSiteProtection.Event.errorPageShown` `clientSideHit` parameter optional. See dicussion in [AsanaTask](https://app.asana.com/0/1206329551987282/1209242004458518/f)
alessandroboron
added a commit
that referenced
this pull request
Feb 5, 2025
) **Required**: Task/Issue URL: https://app.asana.com/0/1206329551987282/1209242004458518/f iOS PR: duckduckgo/iOS#3891 macOS PR: duckduckgo/macos-browser#3796 What kind of version bump will this require?: Minor **Description**: This PR makes `MaliciousSiteProtection.Event.errorPageShown` `clientSideHit` parameter optional. See dicussion in [AsanaTask](https://app.asana.com/0/1206329551987282/1209242004458518/f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1206329551987282/1209242004458518/f
iOS PR: duckduckgo/iOS#3891
macOS PR: duckduckgo/macos-browser#3796
What kind of version bump will this require?: Minor
Description:
This PR makes
MaliciousSiteProtection.Event.errorPageShownclientSideHitparameter optional. See dicussion in Asana TaskSteps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template