Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malsite timeout pixel name #1185

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Jan 23, 2025

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1202406491309510/1209190998168436/f
iOS PR: duckduckgo/iOS#3856
macOS PR: duckduckgo/macos-browser#3772
What kind of version bump will this require?: Patch

Description:

  • Fix Malicious site protection Matches Api timeout pixel name to not contain .
  • make API request structs publicly initializable for testing purposes

Steps to test this PR:

  1. Validate CI is green
  2. see macOS PR for macOS testing steps

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@mallexxx mallexxx merged commit b33273c into main Jan 24, 2025
9 checks passed
@mallexxx mallexxx deleted the alex/fix-malsite-timeout-pixel-name branch January 24, 2025 06:00
mallexxx added a commit to duckduckgo/iOS that referenced this pull request Jan 24, 2025
<!--
Note: This checklist is a reminder of our shared engineering
expectations. Feel free to change it, although assigning a GitHub
reviewer and the items in bold are required.

⚠️ If you're an external contributor, please file an issue first before
working on a PR, as we can't guarantee that we will accept your changes
if they haven't been discussed ahead of time. Thanks!
-->

Task/Issue URL: https://app.asana.com/0/1202406491309510/1209190998168436/f
BSK PR: duckduckgo/BrowserServicesKit#1185
macOS PR: duckduckgo/macos-browser#3772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants