Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sync: Fire accountRemoved KV store reason when no account (#1189)
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1202926619870900/1209014391063056/f iOS PR: duckduckgo/iOS#3875 macOS PR: duckduckgo/macos-browser#3782 What kind of version bump will this require?: Minor **Description**: As part of [✓ Send pixels for account removal + decoding issues](https://app.asana.com/0/1199230911884351/1208723035104886/f), pixels were added indicating what the reason for the Sync account being removed from the Keychain was. However, the pixel `sync_account_removed_reason_not-set-on-key-value-store` is being sent even when there was no account stored in the keychain in the first place. This could be obscuring a problem. To make this Pixel more useful, we should update it so that it's only sent when there was an account stored in the keychain. **Steps to test this PR**: Hard to test the pixel itself as reporting on a broken state, but just do a quick smoke test of Sync on both platforms. <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
- Loading branch information