Authv2 / Networking improvements #3363
federicocappellipr.yml
on: pull_request
Run SwiftLint
36s
Run unit tests (macOS)
4m 48s
Run unit tests (iOS)
2m 58s
Annotations
9 errors, 15 warnings, and 10 notices
|
Run SwiftLint:
Sources/Networking/v2/QueryItems.swift#L1
Header comments should be consistent with project patterns (file_header)
|
|
Run SwiftLint:
Sources/Networking/v2/QueryItems.swift#L24
Shorthand syntactic sugar should be used, i.e. [Int] instead of Array<Int> (syntactic_sugar)
|
|
Run SwiftLint:
Sources/Networking/Auth/OAuthRequest.swift#L251
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
|
Run SwiftLint:
Sources/Networking/Auth/OAuthRequest.swift#L252
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
|
Run SwiftLint:
Sources/Networking/Auth/OAuthRequest.swift#L253
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
|
Run SwiftLint:
Sources/Networking/Auth/OAuthRequest.swift#L272
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
|
Run SwiftLint:
Sources/Networking/Auth/OAuthRequest.swift#L273
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
|
Run SwiftLint:
Sources/Networking/Auth/OAuthRequest.swift#L274
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
|
Run SwiftLint:
Sources/Networking/Auth/OAuthRequest.swift#L169
There should be no space before and one after any comma (comma)
|
|
Run SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Run unit tests (iOS):
DerivedData/Build/Products/Debug-iphonesimulator/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Run unit tests (iOS):
Sources/Networking/Auth/OAuthClient.swift#L269
variable 'legacyTokenStorage' was never mutated; consider changing to 'let' constant
|
|
Run unit tests (macOS):
CoreData#L1
Multiple NSEntityDescriptions claim the NSManagedObject subclass 'DailyBlockedTrackersEntity' so +entity is unable to disambiguate.
|
|
Run unit tests (macOS):
CoreData#L1
'DailyBlockedTrackersEntity' (0x6000039f8e70) from NSManagedObjectModel (0x6000068d3200) claims 'DailyBlockedTrackersEntity'.
|
|
Run unit tests (macOS):
Sources/Navigation/DistributedNavigationDelegate.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
|
Run unit tests (macOS):
Sources/Navigation/Extensions/WKErrorExtension.swift#L67
extension declares a conformance of imported type 'WKError' to imported protocol 'LocalizedError'; this will not behave correctly if the owners of 'WebKit' introduce this conformance in the future
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testOpenAboutBlankInNewWindow
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequest
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterDidStartNavigation
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterWillStartNavigation
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureBeforeWillStartNavigation
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequest
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestWithData
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testWhenWebContentProcessIsTerminated_webProcessDidTerminateAndNavigationDidFailReceived
|
|
Run unit tests (macOS)
Skipped NavigationTests.NavigationRedirectsTests.testWhenCustomSchemeNavigationIsInterruptedByNewRequestThenDidFailIsCalled
|
|
Run unit tests (macOS)
Skipped NavigationTests.NavigationRedirectsTests.testWhenServerRedirectIsInterruptedThenDidFailProvisionalIsCalled
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
build-log.txt
|
60.2 KB |
|
|
ios-build-log.txt
|
299 KB |
|