Skip to content

add tab count to bottom nav bar #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LukasPaczos
Copy link
Contributor

@LukasPaczos LukasPaczos commented Apr 30, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1210044541037881?focus=true

Description

Adds the tab count to the bottom navigation bar's tabs icon. Also introduces a visual cue when there are any tabs that were opened in the background and not visited yet.

I've updated the tabs icon to match the design, but in parallel double checking if these are the right icons.

Steps to test this PR

  • Enabled visual experiment.
  • Verify that:
    • There's a number of tabs visible over the tab icon.
    • If you have 100 or mote tabs open, the number changes to "" character.
    • If you open a tab in the background, a blue highlight appears over the tab icon.
    • If you visit the background tab, the highlight disappears.

Tip: you can use Developer Settings -> Tabs utility to create random tabs.

UI changes

Before After
Screenshot_20250430_152135 Screenshot_20250430_164800
Screenshot_20250430_164808

@LukasPaczos LukasPaczos requested a review from malmstein April 30, 2025 13:31
@LukasPaczos LukasPaczos requested a review from nalcalag as a code owner April 30, 2025 13:31
@LukasPaczos LukasPaczos force-pushed the feature/lukasz-p/add-tab-count-to-bottom-nav-bar branch 2 times, most recently from 72796a2 to 0090ea0 Compare April 30, 2025 14:46
@LukasPaczos LukasPaczos force-pushed the feature/lukasz-p/add-tab-count-to-bottom-nav-bar branch from 0090ea0 to 3614b55 Compare April 30, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant