Skip to content

Support internal FF default value #5978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Apr 28, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1210096516271365?focus=true

Description

Add support for "internal" default value in Toggle.DefaultValue.

Steps to test this PR

Code review that all changed values are correct (even if they were changed with find/replace)
Smoke tests the app
Take one feature that is not in remote config:

  • change its default value to INTERNAL
  • intall play version of the app
  • verify feature is not enabled
  • install internal version of the app
  • verify feature is enabled
  • while in internal build, override the remote config (using override config in dev settings) and disable the feature
  • verify the feature is disabled
  • enable the feature in the remote config
  • verify the feature is enabled

Copy link
Collaborator Author

aitorvs commented Apr 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aitorvs aitorvs force-pushed the feature/aitor/ff/support_internal_default_value branch 2 times, most recently from 47225c9 to b6d930c Compare April 30, 2025 14:35
@aitorvs aitorvs marked this pull request as ready for review April 30, 2025 14:37
@CDRussell CDRussell self-assigned this May 1, 2025
Copy link
Member

@CDRussell CDRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Code reviewed all the changes to ensure they matched their old value still
  • Smoke tested
  • Took existing kill switch not in remote config, androidSkipUrlConversionOnNewTab, and followed the testing steps. all worked as expected.

Note, there's a merge conflict needing resolved.

@aitorvs aitorvs force-pushed the feature/aitor/ff/support_internal_default_value branch from 460610e to 548258a Compare May 2, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants