Support rendering URLs inside sync barcodes #5944
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CDRussell
force-pushed
the
feature/craig/sync_barcode_url_support
branch
6 times, most recently
from
c1e559b to
b3a3796
Compare
16 tasks
CDRussell
force-pushed
the
feature/craig/sync_barcode_url_support
branch
2 times, most recently
from
a1b61b8 to
4ff8eae
Compare
CDRussell
commented
Apr 25, 2025
| } | ||
|
|
||
| companion object { | ||
| const val URL_BASE = "https://duckduckgo.com/sync/pairing/#" |
There was a problem hiding this comment.
this might need to change in a later PR because we’ll need to be able to access this from app module most likely. good for now though, just FYI it’ll probably change.
CDRussell
force-pushed
the
feature/craig/sync_barcode_url_support
branch
6 times, most recently
from
1dc1ad0 to
2ada4fb
Compare
CDRussell
changed the title
CDRussell
force-pushed
the
feature/craig/sync_barcode_url_support
branch
2 times, most recently
from
1072477 to
444943d
Compare
CDRussell
commented
Apr 25, 2025
| barcodeContents?.let { code -> | ||
| clipboard.copyToClipboard(code) | ||
| barcodeContents?.let { contents -> | ||
| clipboard.copyToClipboard(contents.underlyingCode) |
There was a problem hiding this comment.
want to make sure we use the underlying code and not the URL
CDRussell
force-pushed
the
feature/craig/sync_barcode_url_support
branch
2 times, most recently
from
f689aaf to
860b063
Compare
CDRussell
force-pushed
the
feature/craig/sync_barcode_url_support
branch
from
860b063 to
61a59a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1209921184459923?focus=true
Description
Allows sync setup codes which appear in the QR barcode to be URL-based.
ℹ️ Suggested logcat filter:
package:com.duckduckgo.mobile.android.debug message~:"code to include”Steps to test this PR
Get two devices (or one device + one emulator) as you’ll need to scan barcodes.
Feature disabled, everything works as normal
Feature enabled
syncSetupBarcodeIsUrlBasedfeature flag on a device. Note, we expect the URL to be in the barcode but the other device won’t be able to scan it successfully (implemented in a higher branch on this stack) so don’t worry about that part.