Postgres Replacement Scan #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaruza
force-pushed
the
thijs_postgres_scan
branch
from
20e4c10
to
6814034
Compare
|
@JerrySievert @mkaruza is there anything we need to do from our side for this PR? |
|
@Mytherin i have just now create PR for multi threaded scan to be added to this branch. Once we resolve problems (there were some changes how arguments are passed inside duckdb logic which i'm not sure how to resolve) we can merge this into main branch. |
mkaruza
force-pushed
the
thijs_postgres_scan
branch
from
6905d8c
to
9ec60f9
Compare
* Switched from CMake to native Postgres build based on make. Debug version can be compiled with `QUACK_BUILD=Debug make` command. Otherwise release will be built. * Multi-thread scan support. Number of threads per query can be set via `quack.max_threads_per_query` GUC variable (default is 1 thread). * Added basic regression test
mkaruza
force-pushed
the
thijs_postgres_scan
branch
from
9ec60f9
to
5105f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams the changes discussed in the last progress update meeting.
This is essentially
pg_quackupdated to use the C++ API (DuckDB,Connection,Appender,DBConfigobjects)One additional change I've had to make to get it to work with PG16.0 is this, of which I'm not sure this is the equivalent behavior:
Tishj/pg_extension@5b5a678
PostgresReplacementScan
ReplacementScans are a part of DuckDB's extension mechanism, they allow us to hook into a bind of a table ref when that bind can not be fulfilled by the catalog.
We register a replacement scan that receives the
QueryDescobject through theReplacementScanData, in the replacement scan it uses that object to determine whichRangeTblEntrycorresponds to the table we're binding.From the replacement scan we return a
TableFunctionRef, where we essentially transform the received tableref (i.e "tbl") into a call to a table function, providing both theSnapshotand theRangeTblEntryas POINTER to the function.PostgresScanFunction
We create a TableFunction that will use the
SnapshotandRangeTblEntryto scan Postgres using the TableAM interface from within DuckDB.