Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail compilation on warnings #439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fail compilation on warnings #439

wants to merge 1 commit into from

Conversation

Y--
Copy link
Collaborator

@Y-- Y-- commented Nov 15, 2024 •
edited
Loading

  • fail compilation on warnings (-Werror)
  • remove unused parameters
  • fix integer comparisons

@Y-- Y-- requested review from JelteF and mkaruza and removed request for JelteF November 15, 2024 09:29
JelteF
JelteF reviewed Nov 15, 2024
View reviewed changes
src/pgduckdb_metadata_cache.cpp
@@ -75,7 +75,7 @@ uint32 schema_hash_value;
* IsExtensionRegistered for details).
*/
static void
InvalidateCaches(Datum arg, int cache_id, uint32 hash_value) {
InvalidateCaches(Datum, int, uint32 hash_value) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I like this type of change. If we explicitly don't use arguments provided by a hook, I'd like to know what those arguments are used for. Both for reviewing code, but also for when wanting to change behavior of a hook in the future.

JelteF
JelteF reviewed Nov 15, 2024
View reviewed changes
src/pgduckdb_ddl.cpp
@@ -51,7 +51,7 @@ DuckdbTruncateTable(Oid relation_oid) {
}

void
DuckdbHandleDDL(Node *parsetree, const char *queryString) {
DuckdbHandleDDL(Node *parsetree, const char *) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we can just remove this argument, since we control the callsite.

JelteF
JelteF reviewed Nov 15, 2024
View reviewed changes
src/pgduckdb_options.cpp
@@ -200,6 +200,7 @@ DECLARE_PG_FUNCTION(cache) {
}

DECLARE_PG_FUNCTION(pgduckdb_recycle_ddb) {
(void)fcinfo;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit silly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelteF JelteF JelteF left review comments

@mkaruza mkaruza Awaiting requested review from mkaruza

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Y-- @JelteF