Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-matrix the docker platforms #307

Merged
merged 1 commit into from
Oct 18, 2024
Merged

de-matrix the docker platforms #307

merged 1 commit into from
Oct 18, 2024

Conversation

wuputah
Copy link
Collaborator

@wuputah wuputah commented Oct 17, 2024

Docker doesn't like it when you push from separate workers

@wuputah wuputah requested a review from JelteF October 17, 2024 14:41
@wuputah
Copy link
Collaborator Author

wuputah commented Oct 17, 2024

this addresses #303 (comment)

It would be nice to build only natively (i.e. amd64) when doing docker-related PRs and do full builds only on main and tags, but I'll leave that to later improvements.

@wuputah wuputah mentioned this pull request Oct 17, 2024
Docker doesn't like it when you push from separate workers
@wuputah wuputah enabled auto-merge (squash) October 17, 2024 15:02
@wuputah wuputah added the bug Something isn't working label Oct 17, 2024
@Y--
Copy link
Collaborator

Y-- commented Oct 17, 2024

An alternative would be to add the platform in the tag. Less elegant but maybe more efficient when GH comes up with Arm runners for open source projects.

@wuputah wuputah requested a review from Y-- October 17, 2024 20:28
@wuputah wuputah merged commit 3474922 into main Oct 18, 2024
7 checks passed
@wuputah wuputah deleted the jd/dematrix-docker-platform branch October 18, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants