Pre-configure docker image to use pg_duckdb #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
added
documentation
This slightly modifies the default Postgres docker image so that when it initializes the database it will automatically configure `pg_duckdb`.
JelteF
force-pushed
the
docker-enalbe-pg_duckdb-automatically
branch
from
945f051
to
81e4773
Compare
Merged
JelteF
force-pushed
the
docker-enalbe-pg_duckdb-automatically
branch
from
9f800a6
to
592fd90
Compare
…, useful for psql
Y--
approved these changes
Oct 17, 2024
wuputah
reviewed
Oct 17, 2024
| @@ -50,4 +56,10 @@ RUN make installcheck | |||
| ### | |||
| # this creates a usable postgres image but without the packages needed to build | |||
| FROM base AS output | |||
|
|
|||
| # Automatically enable pg_duckdb | |||
| RUN echo "shared_preload_libraries='pg_duckdb'" >> /usr/share/postgresql/postgresql.conf.sample | |||
There was a problem hiding this comment.
ah, I didnt think that you could make changes to the sample file (you know, it being named "sample" and all) and it would get picked up somehow later. TIL. 😂 I think it's still nice to be able to inject a config file for other purposes (like motherduck token) via docker-compose, but if this means that the image works without doing so, then great! 👍
|
|
||
| # Automatically enable pg_duckdb | ||
| RUN echo "shared_preload_libraries='pg_duckdb'" >> /usr/share/postgresql/postgresql.conf.sample | ||
| RUN echo "CREATE EXTENSION IF NOT EXISTS pg_duckdb;" >> /docker-entrypoint-initdb.d/0001-install-pg_duckdb.sql |
There was a problem hiding this comment.
This is probably okay to do here. I was only hesitant to do so in case some users want to opt out of this behavior, doing so this way means they need to make their own image which removes this file. But if we get push back it can always be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly modifies the default Postgres docker image so that when it initializes the database it will automatically configure
pg_duckdb. It also uses thepostgresuser to start the container, so thatdocker exec ... psqljust works without having to specify-U postgresThis also uses a more selective COPY. I often have some random stuff in my top repo directory, such as gigabytes of TPCDS csv files. This makes sure those are not copied into the container.