Remove Tx from TxManager on rollback #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y--
commented
Oct 14, 2024
Comment on lines
+29
to
+30
| lock_guard<mutex> l(transaction_lock); | ||
| transactions.erase(transaction); |
Y--
commented
Oct 14, 2024
Y--
commented
Oct 14, 2024
| if (table->relid) { | ||
| auto rel = RelationIdGetRelation(table->relid); | ||
| auto namespace_oid = RelationGetNamespace(rel); | ||
| RelationClose(rel); |
There was a problem hiding this comment.
Minor cleanup - move it higher since we were closing it in both branches below
JelteF
approved these changes
Oct 14, 2024
JelteF
reviewed
Oct 14, 2024
JelteF
approved these changes
Oct 14, 2024
JelteF
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279
Also adds a test that removes
DuckDBsingleton and re-creates it: this is when the crash was happening.And fully consume the explain output stream from DuckDB