Fix foreach_ptr to work in C++ code #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ is more strict in casting void pointers to other pointers than C, so the upstream foreach_ptr implementation doesn't actually compile on C++. I'll make an upstream patch for that shortly, but for now let's at least fix it in our vendored code.
Y--
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ is more strict in casting void pointers to other pointers than C, so the upstream
foreach_ptrimplementation doesn't compile on C++ when it's actually used. I'll make an upstream patch for that shortly, but for now let's at least fix the problem in our vendored code (all that's needed is an additional cast).