-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support postgresql 14 #266
Conversation
@JelteF Excuse me |
I think the easiest is to change those specific tests to a python test and skip them for PG14. i.e. create a new file To be clear we won't have time to review this in detail or merge this before the 0.1.0 release. But given the small number of necessary changes, I think this can definitely be targeted for 0.2.0. Thank you for your contribution |
Understood. Thank you for your guidance |
test/pycheck/temporary_table_test.py
Outdated
from .utils import Cursor, PG_MAJOR_VERSION, eprint | ||
|
||
|
||
def test_temporary_table(cur: Cursor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def test_temporary_table(cur: Cursor): | |
def test_temporary_table_set_access_method(cur: Cursor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, modified
Did you close this on purpose? I was planning to merge this soon-ish. |
No, no, I see a lot of changes, I plan to reorganize and resubmit. |
Ah alright. Sounds good, yeah we're refactoring a bunch of things to make the C vs C++ division clearer. |
This is good, I also want to try to do a little better, let you misunderstanding, sorry. |
No description provided.