Rewrite COPY ... TO command to match pgduckdb execution #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Oct 9, 2024
JelteF
requested changes
Oct 9, 2024
JelteF
reviewed
Oct 10, 2024
JelteF
approved these changes
Oct 10, 2024
mkaruza
force-pushed
the
copy
branch
2 times, most recently
from
90b297c
to
bce3ff9
Compare
JelteF
reviewed
Oct 11, 2024
Currently COPY ... TO utility is broken due changes in maching table names inside duckb execution. Fix by rewriting COPY command to match table name.
Manually parse OPTIONS part of COPY query. Check settings and allow only combinations that should work with DuckDB execution.
mkaruza
force-pushed
the
copy
branch
2 times, most recently
from
855b33c
to
ca4cbad
Compare
|
@JelteF with your simplification changes this works as expected. |
JelteF
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently COPY ... TO utility is broken due changes in maching table names inside duckb execution. Rewrite
complete query and parse manually each part of copy statement.