-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix builds that use older clang versions #248
Conversation
Another cause looks like our
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it works :-)
151afaf
to
51aafae
Compare
Build is failing for the |
pass PG_CPPFLAGS and PG_CXXFLAGS to COMPILE.cxx.bc like we did for COMPILE.cc.bc this fixes the build on ubuntu:22.04
this rule was not being used as it was replaced when Makefile.global was included
51aafae
to
9379e1e
Compare
pass PG_CPPFLAGS and PG_CXXFLAGS to COMPILE.cxx.bc like we did for COMPILE.cc.bc
this fixes the build on ubuntu:22.04