Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document casing of C implementations of SQL functions #230

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Document casing of C implementations of SQL functions #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ad4d7
Document casing of C implementations of SQL functions
JelteF Sep 30, 2024
046c432
Merge branch 'main' into improve-contributing
JelteF Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ coding styles.
### Postgres C Guidelines

* Use memory contexts to allocate memory, e.g. `palloc` or `palloc0`.
* Casing is very inconsistent in Postgres, we use `CamelCase` for function names and `snake_case` for variables.
* If you copied code from Postgres, try to keep the Postgres style and prefer to keep it in a separate function so that it is easy to update when the Postgres code changes.
* Casing is very inconsistent in Postgres, we use `CamelCase` for function names and `snake_case` for variables. For the C implementation of a SQL function (e.g. `duckdb.install_extension(...)`, use snake_case.
* If you copied code from Postgres, try to keep the Postgres style and prefer to keep it in a separate function/file so that it is easy to update when the Postgres code changes.
* TODO: Add more guidelines here.

### DuckDB C++ Guidelines
Expand Down