Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup after incorrect merge in #97 #210

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Cleanup after incorrect merge in #97 #210

merged 1 commit into from
Sep 24, 2024

Conversation

JelteF
Copy link
Collaborator

@JelteF JelteF commented Sep 24, 2024

I think @Tishj misunderstood my review comment in #97 about the merge being incorrect. I meant that the whole pgduckdb_pg_get_querydef stuff could be removed from DuckdbPlanNode, since that is now moved to DuckdbPrepare.

@JelteF
Cleanup after incorrect merge in #97
4b0c4c5 
I think @Tishj misunderstood my review comment in #97 about the merge
being incorrect. I meant that the whole `pgduckdb_pg_get_querydef` stuff
could be removed from `DuckdbPlanNode`, since that is now moved to
`DuckdbPrepare`.
Tishj
Tishj approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, query_string is completely unused here because we prepared it earlier

@JelteF JelteF merged commit 9c00a10 into main Sep 24, 2024
3 checks passed
@JelteF JelteF deleted the fixup-after-bad-merge branch September 24, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tishj Tishj Tishj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelteF @Tishj