Make DuckDB connection a singleton #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #174 we made the DuckDB database a singleton, but a new DuckDB connection was still being created for every query. This means that any connection state, such as SET commands or temporary tables don't survive a single query, which is pretty confusing. This addresses that by also making the `duckdb::Connection` a singleton, this way a Postgres connection and a DuckDB connection are linked 1-to-1.
|
FYI I'm postponing working on this until later, since it's not needed for the first release and the current implementation has bugs with non-obvious causes. |
JelteF
added a commit
that referenced
this pull request
Oct 7, 2024
|
Closing this in favor of #413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #174 we made the DuckDB database a singleton, but a new DuckDB connection was still being created for every query. This means that any connection state, such as SET commands or temporary tables don't survive a single query, which is pretty confusing. This addresses that by also making the
duckdb::Connectiona singleton, this way a Postgres connection and a DuckDB connection are linked 1-to-1.