Add duckdb.raw_query function #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For upcoming features, specifically MotherDuck support it is quite useful to be able to send raw queries to DuckDB to inspect the current state of the database. Such as `DESCRIBE` or `SELECT * FROM duckdb_tables();` or even queries to debug the our current `SECRET` support. This adds a small helper function to do this. The result is shown in a NOTICE message instead of actually returning them as rows, so that there's no need for the `AS (some_column int, some_other_column text)` stuff. We'll probably want a function that returns actual rows too for use in scripts, but this is a bit easier to use for debugging at the moment. It's specifically named `duckdb.raw_query`, so we can use `duckdb.query` for the function that actually returns rows.
wuputah
approved these changes
Sep 24, 2024
|
CI is failing on main / subsequent PRs due to a table oid mismatch. --- /home/runner/work/pg_duckdb/pg_duckdb/duckdb/test/regression/expected/raw_query.out 2024-09-24 18:56:04.958433346 +0000
+++ /home/runner/work/pg_duckdb/pg_duckdb/duckdb/test/regression/results/raw_query.out 2024-09-24 18:56:34.711724950 +0000
@@ -13,7 +13,7 @@
NOTICE: result: database_name database_oid schema_name schema_oid table_name table_oid comment tags internal temporary has_primary_key estimated_size column_count index_count check_constraint_count sql
VARCHAR BIGINT VARCHAR BIGINT VARCHAR BIGINT VARCHAR MAP(VARCHAR, VARCHAR) BOOLEAN BOOLEAN BOOLEAN BIGINT BIGINT BIGINT BIGINT VARCHAR
[ Rows: 1]
-memory 1148 main 1150 t 1266 NULL {} false false false 0 1 0 0 CREATE TABLE t(a INTEGER);
+memory 1148 main 1150 t 1269 NULL {} false false false 0 1 0 0 CREATE TABLE t(a INTEGER);
|
|
Ugh, lets remove the test for now then. |
|
See #214 |
JelteF
added a commit
that referenced
this pull request
Sep 24, 2024
This quickly removes a test that is now failing in CI. In another PR I'll try to add a non-flaky test back, but this removes the immediate problem. The problematic test was added in #203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For upcoming features, specifically MotherDuck support it is quite useful to be able to send raw queries to DuckDB to inspect the current state of the database. Such as
DESCRIBEorSELECT * FROM duckdb_tables();or even queries to debug the our currentSECRETsupport. This adds a small helper function to do this. The result is shown in a NOTICE message instead of actually returning them as rows, so that there's no need for theAS (some_column int, some_other_column text)stuff. We'll probably want a function that returns actual rows too for use in scripts, but this is a bit easier to use for debugging at the moment. It's specifically namedduckdb.raw_query, so we can useduckdb.queryfor the function that actually returns rows.