support postgresql 15 #180
Conversation
|
But there's a little problem I don't know how to deal with |
|
'\getenv pwd PWD' is better transformed into '\set pwd' pwd ', which is more general and suitable for more PG versions. #178 |
|
Ragarding the problem, you need to apply the equivalent of this change to the ruleutils.c file too: d62ba97 |
That's one step missing. Thank you for your help |
|
Or is there something that needs to be improved in this pull request and is looking forward to your suggestions |
|
Can you make sure this is also run in CI, by adding |
Okay, thanks. I'll try. |
There was a problem hiding this comment.
Some final suggestions, but after that it's good to merge IMO.
@wuputah @mkaruza do any of you have some feedback on this. If not I'll squash some of the commits after my final feedback is addressed, and then merge this in a way that preserves the history nicely (specifically the initial copy of the PG15 ruleutils).
Go for it. Tests pass so 👍 |
|
@Leo-XM-Zeng sorry for the delay. We had some discussion in person about PG version support, given this is a young project and would like to move fast. The result of that discussion can be fonud here: #154 (comment) tl;dr we'd like to merge this PG15 support. Could you fix the merge conflict? Then I'll merge it after. Thank you for all your work on this. |
Ok, just a moment, please. |
|
@JelteF oh, this error is due to unsupported syntax in the current psql15 version |
|
Alright, let's remove that test. We have enough other prepared statement tests in the |
|
to be clear, not remove the whole basic.sql just the lines that use |
understand |
I'm sorry for the delay because I changed my computer and had some problems with the network |
JelteF
force-pushed
the
pg_duckdb_15
branch
from
bd6e4ee
to
ef3a153
Compare
This vendors in the PG15 version of the ruleutils.c file from Postgres. We've done the same already for PG16 and PG17 in e963297, but now in preparation of PG15 support we also include the PG15 version.
This applies changes to pg_ruleutils_15.c that are identical to the ones that we already made to the PG16 and PG17 versions of these files. It also notably removes tests involving the psql \bind meta-command, because those meta-commands are unsupported by PG15 its psql. This is acceptable because we Other than that this mainly adds a bunch of #if PG_VERSION_NUM >= 160000 preprocessor statements in places where APIs diverge between versions.
JelteF
force-pushed
the
pg_duckdb_15
branch
from
ef3a153
to
e889d9a
Compare
The PG15 support that was introduced in #180 introduced a bunch of warnings when compiling. To avoid getting numb to warnings, this adds the -Werror to our CI builds, so we catch warnings before merging to main. This also starts to ignore the register warning which was introduced by PG15 support.
The PG15 support that was introduced in #180 introduced a bunch of warnings when compiling. To avoid getting numb to warnings, this adds the -Werror to our CI builds, so we catch warnings before merging to main. This also starts to ignore the register warning which was introduced by PG15 support.
No description provided.