Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in execution #176

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Handle errors in execution #176

merged 5 commits into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    490361c View commit details
    Browse the repository at this point in the history
  2. Handle errors in execution

    * Unify reporting of WARNING with log
    * Throw exception in functions that are used inside duckdb execution
    * Report WARNING for functions that are part of "normal" postgres
      execution
    * Cleanup duckdb_state before reporting error in DuckDBNode (clean up)
    mkaruza committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    29aa8c9 View commit details
    Browse the repository at this point in the history
  3. Add guard for handling Postgres function calls

    * Added `PostgresFunctionGuard` and `PostgresVoidFunctionGuard` that
      handle call to Postgres function that can throw ERROR.
    mkaruza committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    12f2ba1 View commit details
    Browse the repository at this point in the history
  4. Extend CONTRIBUTING.md with error handling information

    * Add few informations how we should handle errors inside code.
    * Use same function name `PostgresFunctionGuard` for both void and
      non-void PG function calls.
    mkaruza committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e5768d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Review feedback changes

    * Guard function throw `duckdb::Exception(EXECUTOR,...)`
    * Updated CONTRIBUTING.md according to review suggestion
    * Guarded other suggested pg functions
    mkaruza committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    466d77e View commit details
    Browse the repository at this point in the history