Add pytest-based testing framework #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
force-pushed
the
pytest-tests
branch
14 times, most recently
from
afa2cee
to
e4876b1
Compare
JelteF
added a commit
that referenced
this pull request
Aug 21, 2024
The PostgreSQL license is very liberal but, like MIT and BSD, it does require attribution and requires that the original license is included. This adds a NOTICE file containing the license, because we've vendored in a few files/functions from the Postgres repository and we'll likely need to vendor in more. If/when we decide to to merge #143 we should also include PgBouncer its license. Which is the ISC license, which is also attribution-only.
mkaruza
approved these changes
Sep 2, 2024
|
Ruff is for auto formatting |
mkaruza
pushed a commit
that referenced
this pull request
Sep 11, 2024
The PostgreSQL license is very liberal but, like MIT and BSD, it does require attribution and requires that the original license is included. This adds a NOTICE file containing the license, because we've vendored in a few files/functions from the Postgres repository and we'll likely need to vendor in more. If/when we decide to to merge #143 we should also include PgBouncer its license. Which is the ISC license, which is also attribution-only.
mkaruza
pushed a commit
that referenced
this pull request
Sep 11, 2024
`pgregress` is easy to use an is part of Postgres, so it's often the first thing to use testing a Postgres extension. But it also quite limiting, since you can only execute SQL and a test fails as soon as any of the output is different. This adds a Python based testing framework to the project, which allows to do more "application" style testing. It's based on the testing framework I wrote for PgBouncer, but I removed a bunch of stuff that only made sense when testing PgBouncer. Postgres has a similar framework included, but that uses Perl and I really don't want to write any Perl. Also `pytest` is a much nicer to use testing framework than what is available in Perl. As an example of a test that cannot easily be written using `pgregress` I added a test for `EXPLAIN ANALYZE`. Support for `EXPLAIN ANALYZE` was added in #136, but writing a test was not possible because the Timing information would be flaky.
|
I love this, |
|
This could also be used to make #88 testable, verifying that files are correctly downloaded, multiple processes can make use of it and not break etc.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgregressis easy to use an is part of Postgres, so it's often the first thing to use testing a Postgres extension. But it also quite limiting, since you can only execute SQL and a test fails as soon as any of the output is different.This adds a Python based testing framework to the project, which allows to do more "application" style testing. It's based on the testing framework I wrote for PgBouncer, but I removed a bunch of stuff that only made sense when testing PgBouncer. Postgres has a similar framework included, but that uses Perl and I really don't want to write any Perl. Also
pytestis a much nicer to use testing framework than what is available in Perl.As an example of a test that cannot easily be written using
pgregressI added a test forEXPLAIN ANALYZE. Support forEXPLAIN ANALYZEwas added in #136, but writing a test was not possible because the Timing information would be flaky.