Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: use the Makefile from duckdb for the git submodule update target #14

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

wuputah
Copy link
Collaborator

@wuputah wuputah commented Apr 18, 2024

The directory already exists when you do a fresh clone, so the existing target was effectively a no-op. This will instead ensure the duckdb Makefile exists.

@wuputah wuputah requested review from mkaruza and Tishj April 18, 2024 19:18
Copy link
Collaborator

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, the directory was just empty before I guess?
So putting the Makefile as the result of the recipe makes it detect that the directory is empty?

@wuputah
Copy link
Collaborator Author

wuputah commented Apr 18, 2024

yep, exactly.

@wuputah wuputah merged commit d4ffc83 into main Apr 18, 2024
2 checks passed
@mkaruza mkaruza deleted the jd/fix-auto-git-submodule-init branch April 19, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants