PR Feedbacks

duckdb · Oct 21, 2024 · 65da870 · 65da870
1 parent f6ec22b
commit 65da870
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 9 deletions.
diff --git a/src/pgduckdb_duckdb.cpp b/src/pgduckdb_duckdb.cpp
@@ -162,9 +162,9 @@ DuckDBManager::LoadSecrets(duckdb::ClientContext &context) {
 
 		pfree(secret_key->data);
 		++secret_id;
+		secret_table_num_rows = secret_id;
 	}
 
-	secret_table_num_rows = secret_id;
 }
 
 void

diff --git a/test/regression/expected/extensions.out b/test/regression/expected/extensions.out
@@ -1,4 +1,4 @@
-SET duckdb.execution TO false;
+SET duckdb.force_execution TO false;
 SELECT * FROM duckdb.raw_query($$ SELECT extension_name, loaded, installed FROM duckdb_extensions() WHERE loaded and extension_name != 'jemalloc' $$);
 NOTICE:  result: extension_name	loaded	installed	
 VARCHAR	BOOLEAN	BOOLEAN	
@@ -94,4 +94,3 @@ pgduckdb	true	false
 
 (1 row)
 
-SET duckdb.execution TO true;
diff --git a/test/regression/expected/secrets.out b/test/regression/expected/secrets.out
@@ -78,4 +78,3 @@ pgduckb_secret_0
 
 (1 row)
 
-SET duckdb.force_execution TO true;
diff --git a/test/regression/sql/extensions.sql b/test/regression/sql/extensions.sql
@@ -1,5 +1,5 @@
 
-SET duckdb.execution TO false;
+SET duckdb.force_execution TO false;
 
 SELECT * FROM duckdb.raw_query($$ SELECT extension_name, loaded, installed FROM duckdb_extensions() WHERE loaded and extension_name != 'jemalloc' $$);
 
@@ -26,5 +26,3 @@ DELETE FROM duckdb.extensions WHERE name = 'aws';
 SELECT last_value FROM duckdb.extensions_table_seq;
 
 SELECT * FROM duckdb.raw_query($$ SELECT extension_name, loaded, installed FROM duckdb_extensions() WHERE loaded and extension_name != 'jemalloc' $$);
-
-SET duckdb.execution TO true;
diff --git a/test/regression/sql/secrets.sql b/test/regression/sql/secrets.sql
@@ -27,5 +27,3 @@ DELETE FROM duckdb.secrets WHERE key_id = 'access_key_id_1';
 SELECT last_value FROM duckdb.secrets_table_seq;
 
 SELECT * FROM duckdb.raw_query($$ SELECT name FROM duckdb_secrets() $$);
-
-SET duckdb.force_execution TO true;