Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rename script to properly handle snake case extensions #40

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix rename script to properly handle snake case extensions #40

merged 1 commit into from
Oct 11, 2023

Conversation

samansmink
Copy link
Collaborator

fixes #38
applies the ideas of #39

Should now properly handle extension names:

  • only valid snake case allowed as input, no digits as first char.
  • correctly produce camelcase for c++ classes
  • updated the extension template CI to test this with a more tricky name

@samansmink samansmink mentioned this pull request Oct 6, 2023
Closed
@samansmink samansmink requested a review from carlopi October 9, 2023 08:09
@samansmink samansmink merged commit ca53e15 into duckdb:main Oct 11, 2023
11 checks passed
@samansmink samansmink deleted the fix-name-script branch October 11, 2023 07:20
@samansmink samansmink restored the fix-name-script branch October 11, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlopi carlopi carlopi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename is broken
2 participants
@samansmink @carlopi