Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the secret creation to a connection-level operation instead of a cursor-level operation #468

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Move the secret creation to a connection-level operation instead of a cursor-level operation #468

merged 2 commits into from
Oct 18, 2024

Conversation

jwills
Copy link
Collaborator

@jwills jwills commented Oct 18, 2024

Fixes #467

@jwills jwills requested a review from guenp October 18, 2024 17:00
guenp
guenp approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@guenp guenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@jwills jwills merged commit d0c409b into master Oct 18, 2024
33 checks passed
@jwills jwills deleted the jwills_make_secret_construction_threadsafe branch October 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guenp guenp guenp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jwills @guenp