[pull] devel from submariner-io:devel #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This requires pulling in the host configuration for dnf. dnf_install is fixed to fail if dnf fails (otherwise dnf errors don't stop the build). The ulimit configuration is only applied if it reduces the current limit (in setups where the ulimit is less than 1048576, dnf_install would attempt to raise it, which isn't allowed, and now causes the whole script to fail). Signed-off-by: Stephen Kitt <[email protected]>
This fixes a few buildx warnings:
* BASE_BRANCH needs a default value
* specifying ${TARGETPLATFORM} is redundant
* entrypoints should be specified as JSON arrays (this doesn't change
anything in practice for Submariner, since the entrypoints are
shell scripts which correctly set up signal handling)
Signed-off-by: Stephen Kitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )