Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put inner multireweight script in CONVERGECAST-COLLECT-ROOTS #52

Merged
merged 4 commits into from
Dec 3, 2023

Conversation

Copy link
Contributor

@ecpeterson ecpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the semantic difference here. Is there one? The only change of that sort I see is the missing aborting? check that used to wrap the "inner" routine.

Looking at this, I feel that "inner" was a misnomer — we haven't yet acquired the locks, so how could we be in the critical section? — so I don't mind renaming / reorganizing it. If all the other operations do have critical sections demarcated as inner subroutines (which I think is true? at least all the primary ones do, though maybe not reweight...), then I'd prefer that this one still have a (properly defined) inner subroutine too. But none at all is better than an improper one.

@karalekas karalekas merged commit 9242988 into main Dec 3, 2023
1 check passed
@karalekas karalekas deleted the no-more-inner-multireweight branch December 3, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants