Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add redis cluster support #508

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

cloorc
Copy link
Contributor

@cloorc cloorc commented May 29, 2024

This PR will close request #507 .

Please have a look. thanks!

@cloorc cloorc force-pushed the main branch 2 times, most recently from 94a988e to d4baba0 Compare May 29, 2024 10:36
@cloorc
Copy link
Contributor Author

cloorc commented May 29, 2024

@yedf2 Hi, would you please help to review this PR? Thanks a lot!

@cloorc
Copy link
Contributor Author

cloorc commented May 29, 2024

This PR will also resolve redis#Ping() issue in github.com/go-redis/redis/v8 for redis#ClusterClient by upgrading github.com/go-redis/redis/v8 to github.com/redis/go-redis/v9.

@yedf2
Copy link
Contributor

yedf2 commented May 29, 2024

Can you make a small typo PR? I'll merge it and you'll be granted privileges to run CI.

After that, you can fix the CI error for this PR.

@cloorc
Copy link
Contributor Author

cloorc commented May 30, 2024

Can you make a small typo PR? I'll merge it and you'll be granted privileges to run CI.

After that, you can fix the CI error for this PR.

Yeah. This PR will only make it possible to connect to redis cluster.

But the old github.com/go-redis/redis/v8 has issue when ping the cluster. So I had to upgrade it to github.com/redis/go-redis/v9.

@cloorc
Copy link
Contributor Author

cloorc commented May 30, 2024

Can you make a small typo PR? I'll merge it and you'll be granted privileges to run CI.

After that, you can fix the CI error for this PR.

I've submitted a new typo PR: #509 , please have a look.

@cloorc
Copy link
Contributor Author

cloorc commented May 31, 2024

@yedf2 Sorry, it seems unable to restart failed action Tests/CI(pull_request) https://github.com/dtm-labs/dtm/actions/runs/9311309876/job/25630279151?pr=508 . It seems like failed because of unable to upload result.

@cloorc
Copy link
Contributor Author

cloorc commented May 31, 2024

@yedf2 Sorry, it seems unable to restart failed action Tests/CI(pull_request) https://github.com/dtm-labs/dtm/actions/runs/9311309876/job/25630279151?pr=508 . It seems like failed because of unable to upload result.

It seems like secret.CODECOV_TOKEN can't be read in my PR.

@yedf2 yedf2 merged commit 741b6ab into dtm-labs:main May 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants