Migrationer #8
Merged
Migrationer #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malmz @The1Penguin sanity check please 🥺 |
The1Penguin
reviewed
Jun 12, 2024
The1Penguin
reviewed
Jun 12, 2024
The1Penguin
reviewed
Jun 12, 2024
Multipacker
reviewed
Jun 12, 2024
Co-authored-by: Simon Renhult <[email protected]>
malmz
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Ser bra ut, känns som något som skulle kunna lösas med ett migrations verktyg men några av våra tjänster kan väl vara lite wild and crazy.
Lite sus transaktionslösa operationer som förmodligen är fine för sqlite har typ inte concurrency och det kör innan appen startas så w/e.
|
beep boop, get merged bozo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TV mannen skulle gärna behövas pillas lite på, saker som hade varit nice är typ
Dessa skulle garanterat kräva ändringar i vårt databas schema, så vi bör ha något system för migrations.
PR:et inkluderar ett simpelt system för migrationer och en migration som ändrar så att våra strängar inte längre har maxländger (onödigt, och trivialt att migrera p.g.a hur sqlites typer funkar).
Skapar detta PR för att få lite code-review sanity check innan jag mergar till main :)