Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a flake build instead of shell.nix #119

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Added a flake build instead of shell.nix #119

merged 1 commit into from
Oct 11, 2023

Conversation

The1Penguin
Copy link
Contributor

Good luck

@The1Penguin
Copy link
Contributor Author

Note, this will be used to make a new dockerfile to replace the current, and avoid stack

Rembane
Rembane requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@Rembane Rembane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative and good stuff overall! See inline comments for questions and things I think would be better if changed.

src/View.hs Outdated Show resolved Hide resolved
shell.nix Show resolved Hide resolved
mat-chalmers.cabal Show resolved Hide resolved
Rembane
Rembane reviewed Sep 25, 2023
View reviewed changes
flake.nix Show resolved Hide resolved
@The1Penguin The1Penguin force-pushed the update-flake branch 2 times, most recently from cdf334c to d30c062 Compare September 27, 2023 22:43
@Rembane Rembane self-requested a review October 11, 2023 18:02
Rembane
Rembane previously requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Rembane Rembane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over to @Jassob !

Jassob
Jassob approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Jassob Jassob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would also like to avoid non-necessary code changes in this PR.

Also, what happened to the space? 🤔

src/View.hs Outdated Show resolved Hide resolved
@Jassob
Copy link
Contributor

Jassob commented Oct 11, 2023

Also, let's squash merge everything 👌

Jassob
Jassob reviewed Oct 11, 2023
View reviewed changes
flake.nix Show resolved Hide resolved
@The1Penguin @Jassob
Added a flake build instead of shell.nix
77fa586 
Added for ability to compile

update to newer lts while we are at it

I am very tired
@Jassob Jassob merged commit eb8c47b into main Oct 11, 2023
2 checks passed
@Jassob Jassob deleted the update-flake branch October 11, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jassob Jassob Jassob approved these changes

@Rembane Rembane Rembane left review comments

@sora-jp sora-jp Awaiting requested review from sora-jp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The1Penguin @Jassob @Rembane