Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten the main function #116

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Flatten the main function #116

merged 1 commit into from
Sep 27, 2023

Conversation

Rembane
Copy link
Contributor

@Rembane Rembane commented Sep 25, 2023 

Flatten the main function

This should make it a bit easier to read while hopefully making it
easier to change in the future.

Use pattern matching to see if the user wants to the see the usage
instructions, this allows us to make use of one `case` expression
instead of a `case` expression and an `if` expression.

Do configuration reification pointfree style while using lenses.

@Rembane Rembane requested review from The1Penguin and a team September 25, 2023 11:37
Rembane
Rembane commented Sep 27, 2023
View reviewed changes
app/Main.hs Outdated Show resolved Hide resolved
@Rembane Rembane force-pushed the flatten-the-main-function branch 2 times, most recently from 3c01d2c to 7351c1a Compare September 27, 2023 18:51
@Rembane @Jassob
Flatten the main function
ca718be 
This should make it a bit easier to read while hopefully making it
easier to change in the future.

Use pattern matching to see if the user wants to the see the usage
instructions, this allows us to make use of one `case` expression
instead of a `case` expression and an `if` expression.

Do configuration reification pointfree style while using lenses.

Co-authored-by: Jacob "Jassob" Jonsson <[email protected]>
Jassob
Jassob approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Jassob Jassob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of big change

@Rembane Rembane merged commit 2f723e0 into main Sep 27, 2023
2 checks passed
@Rembane Rembane deleted the flatten-the-main-function branch September 27, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jassob Jassob Jassob approved these changes

@The1Penguin The1Penguin Awaiting requested review from The1Penguin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rembane @Jassob