Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline fonts to not accidentally leak data to 3rd party hosting the fonts #114

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

Rembane
Copy link
Contributor

@Rembane Rembane commented Sep 24, 2023

No description provided.

@Rembane Rembane linked an issue Sep 24, 2023 that may be closed by this pull request
@Rembane Rembane requested review from Kirens, The1Penguin and a team September 24, 2023 11:16
Web Fonts have the potential to leak data to where they are fetched
from, in our case it is Google Web Fonts. By inlining them we do not
leak data anywhere.

Close #74.
@Rembane Rembane force-pushed the 74-put-the-static-assets-on-the-local-server branch from a8fa316 to 92ec7fa Compare September 24, 2023 11:17
Copy link
Contributor

@The1Penguin The1Penguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@icicel icicel merged commit 05f7c1e into main Sep 24, 2023
2 checks passed
@icicel icicel deleted the 74-put-the-static-assets-on-the-local-server branch September 24, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put the static assets on the local server
3 participants