Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invisible space #113

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

89netraM
Copy link
Contributor

Currently, when copying menu items from the web page the header of each item is joined with the contents. This PR adds a space between the two, without making any visible changes.

@Rembane
Copy link
Contributor

Rembane commented Sep 18, 2023

Currently, when copying menu items from the web page the header of each item is joined with the contents. This PR adds a space between the two, without making any visible changes.

Good evening,

Thank you for the contribution!

Could you tell me more about the use case for this change. What problem does this solve? I'm a bit tired, hungry and stupid right now, so I've probably missed something that's incredibly clear to you. :)

@89netraM
Copy link
Contributor Author

Haha, yep, probably only clear to me.
I don't know anything about food. I often want to look up the food online before deciding what seems tasty and not. To do this I want to select the menu text, I do this by double clicking and selecting text word by word, without the space my browser sees the menu header and the first word of menu text as a single word.

@Rembane
Copy link
Contributor

Rembane commented Sep 18, 2023

Haha, yep, probably only clear to me. I don't know anything about food. I often want to look up the food online before deciding what seems tasty and not. To do this I want to select the menu text, I do this by double clicking and selecting text word by word, without the space my browser sees the menu header and the first word of menu text as a single word.

I think that's an incredibly good reason. Can you add that explanation to the commit message? Because if you do the next person who wonder why there exists an invisible space there can run git blame and see your explanatory commit message.

  • git commit --amend
  • And then git push -f
  • Are a good combo of commands if you didn't know them already. :)

The invisible space separates the menu header from the text, which makes
for a much better user experience when selecting word by word.
@89netraM
Copy link
Contributor Author

Sure, fixed ✅

And thanks for responding so quickly!

@Rembane Rembane self-requested a review September 18, 2023 18:26
Copy link
Contributor

@Rembane Rembane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a useful change. It also works. It's ready to merge!

@Rembane
Copy link
Contributor

Rembane commented Sep 18, 2023

Sure, fixed ✅

And thanks for responding so quickly!

No worries, this was fun! :D

@Rembane Rembane merged commit ddb9040 into dtekcth:main Sep 27, 2023
1 check passed
@Rembane
Copy link
Contributor

Rembane commented Sep 27, 2023

@89netraM I took the executive decision to merge this PR. Thank you again the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants