chore: inline all static files #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ni borde ta bort icon filen // Jassob (via Kiren (via Jassob)) |
Now that we no more include static files we can remove: - wai-middleware-static-embedded - file-embed
Jassob
force-pushed
the
chore/inline-all-static-files
branch
from
c39c5ca
to
3b03d5b
Compare
|
@Kirens favicon removed 👌 |
The1Penguin
reviewed
Sep 14, 2023
| @@ -69,7 +69,7 @@ sitehead = head_ | |||
| (do | |||
| meta_ [charset_ "utf-8"] | |||
| meta_ [name_ "viewport", content_ "width=device-width, initial-scale=1"] | |||
| link_ [rel_ "icon", type_ "image/png", href_ "icon.png"] | |||
| link_ [rel_ "shortcut icon", id_ "icon", type_ "image/png", href_ "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAYAAACqaXHeAAAABHNCSVQICAgIfAhkiAAAAAlwSFlzAAAN1wAADdcBQiibeAAAABl0RVh0U29mdHdhcmUAd3d3Lmlua3NjYXBlLm9yZ5vuPBoAAAbcSURBVHic7ZpriFVVFMd/y8ZHqahjNupooUWW0QszU7M0tCeVpUmhvYPwg1RmGlhRUJH00KgQLUQhKopMk6TStMKKsrCUNB9p4viecjTDR+PsPqx9vXv2Pefcc+7c65G8f9jc/VhrnbXXWWvvtfe5YozhREaztBVIG2UDpK1A2igbIG0F0kbZAGkrkDbKBkhbgbRRNkDaCqSNsgHSVuBYQER6ikiHoLFmHuFAEam29d4iMkNErrftQSLypoj0te0RIjJdRM4s9QSaAhEZA6wHtorIuTkExhjskXgcYIADQCdgiW3/DbQFamx7tR0/ZNtzMzKOtwJc7uhpgIk+jesBV9nfVsAAoKdttwGqbcH2VwMtnPZxBxHpCXxEVk+AU3y6CpcnpF5SiEhLoDPqebtNEW5oRKQCWACc6g218Gkr/I5SQkSaAQOBm4GhQHeg0iGpF5EdwBrgY2C+MWZLAY+6C+gd0N8yp8eJl3lkY2U48IfTPsepHwQucto/x4jFVsDjwC6HL25ZBlyZIO4rgA0hsl736UvuASJyJ/Ac+rZdbAJWAjtsORkNhWqgP9l4HQh8KSILgAnGmHV5Hnk9ELYzHbsQEJEWwAzgHqe71vZ9CGwBLkUn3MWOrUQ9bxUaIqOBW9A16UZgsIiMMcZ8HPHogRFjxyYE0G3yG4fmb+AZoCMwFvgaqCfc7f8C3kZ3o4uBz5yxBmByRAh8FSH3vRz6YhsAdeXlzvg6oBdwO7AxQrmwMhfdasd5RpsQMHkB9kfJisoDXJxG4/CoduoCdA3hA5gFXGLrS9Fk5BHgXaBHBF8YbgF+AtYC16LeBDAlk6VmYLfQnDh3EDsEkpQVjoyHnP41aCgsLlCuX+qBu9G14Ijt2wt097xgR4SMxVEh8GKBis2x/JXAHttXB5wNzC7S5DPlMHAFMMnpm+UZYHUE/9dRBhhUoFKjLP/LTt/D6GJXzMlnym6gClhh20eA85x5LIvg/T7KACcBvyZUZj16UKoke+jYiK4htSUygAHeAIY57bedecyN4MvdsQK2r19iKlEDnGH57nL6HwSeL+HkDfAvmux8Z9t1QHOry/0RfKsjDWAFdABeQw8nYYIWAT0cng/JumMV2aNzKcuTwASnPczq0h7dqoN4fs9rAGdSXdCF0c3fVwEjPbpmZPfeZegWWOrJG+BH4CynPTVGGNTENoAj7BVHwNMB452d8Ze8t1Lq0hb409bnOToNC6HfFTcRctHGqbcOGHeTohpyDz2lRDdgu6+HMWYReh/gIycRimOA1iH1DLo49Rqis8RioytZA3TxxsajeYOLJhugTcC48eSZAJpSwZCdQ6PnGmM2AFM9+pw0uRghsN2pVwNbY8gsFraia5CvRwbPev0iIs1dgmKEwDan3g0Ng2MBgxog4/rbcgiM2Q+873U3CoOkHhAUArvRbRD0/L40hsxi4EfU4zIfPDaG0PkvrVEYNNkDjDENwKe22Q99E4VcZCbFfPRyNYOFIXTtvXZiD8gXAqBHadC7gluBOTHkNgWHgXeAkbZdh94EBaGd1268E8RIhP4hm0hsDaHpQDZ13owehgq5AY5bpgHXOe3ZEfr/4PGeHTsTRN9og8O8N4J2ikP3GPBAiSa/Az20rbTteqBXhF5rPf7zkxigtcdcH0Hbnmxaug/9MDGzyJM/iF6ZP+X0zcwzh52ejD5JDFAVoETLCHr3EmQ9GgoLizT5w8Ad6BqT8co9QNc8c/BPhgOSGKBngCId8/DMcWiXoYnKtCZOvhYYjN4HZk6e9dgjcIQurQJkDUligAsCBJyeh6cl8K1Dvxm92x8O/JZw4g3oan86MJnG69G4GAt45wCZ1yQxQP8AAefGeHAlmhBleA6hx+oq4F7gc+vSYRPfCbwF9EGv1V2D1gOP5tPB6tErQPZNSQwwNEBA35gPrwCme7x16OXpIHTRvAq4E5iIfvgYYSd9qu331489/hvMo0O/AP1vc2nyfRsMSn3DkqFGMMbUA2NFZAnwArqetEOPqePRuF6F5vPb0C9KQ1B3v5Dc75YfAJOMMZviPN/CT4LAPxHmseBoci14Q9w34MhpgV6VJ70rPIJ+WLks6TPtc0cFyLwviQcEve0gr4iEMeYwME1EXkXvDN0/SFShV/KgWed2sn+QWGCM2Zn0eQ6CPKBRKlyyEAiC0dey3JYn4Oi/RjoBB4wx+wqVHQL/IAReCBTiAQUbIAhGT5NNectRCPpQ2uA28p0GNwQwh527j0dMA74gm1MsQNPzoxC7WIRCRK4GrkEXpE+MMWHHzuMWIlIFHDHG1OaM5TPA/x0nxH+Fo1A2QNoKpI2yAdJWIG2UDZC2AmnjP4d/p142yV/iAAAAAElFTkSuQmCC"] | |||
There was a problem hiding this comment.
Does this line need to be that long? It feels difficult for a maintainer to see its use.
|
En rad base64 ska det va! (detta är hemskt) |
|
Okej, det var lite roligt att inlinea allting och bli av med filer (vi sparade hela 4 rader på denna refaktorering!), men som vi alla ser så blir det oerhört mycket besvärligare att maintaina. Så låt oss stänga denna PR och låtsas som att vi gjorde något vettigare igår kväll istället för att spendera så mycket tid på att inlina favicons 🙈 |
|
Starkt medhåll på den här, det var väldigt kul att göra dumheter tillsammans med @Jassob under en hackkväll och nu stänger vi den här PRen och gör något mer konstruktivt med våra liv. 😸 |
|
|
|
@SimonAlling Hackkväll happened. 'twas legendary! |
|
@Rembane: Ja, så långt var jag med! 😄 Skämt åsido dock – med tanke på att eventuella syntaxfel i CSS-koden leder till ⊥ vid run time kanske det skulle vara helt rimligt att inline:a CSS-koden i något DSL i vilket endast giltig CSS kompilerar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't like TemplateHaskell, so we removed it and handled the consequences.
Pls merge :D