-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature internal 57 logging remaining #468
Conversation
…s to enable the plot to work with the current inheritance structure.
…itance structure
…ngs, and instead of logging when there is an error with reading the config file, exit.
…feature_internal_57_logging_remaining
…feature_internal_57_logging_remaining
…feature_internal_57_logging_remaining
Co-authored-by: Julie Prestopnik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all of your work on this task, @bikegeek. Before the minor change, I noted that all tests passed, so I expect them to pass again. Thank you for the paths to your log files - it made it easy for me. I verified the presence of the user ID/name, timestamp, start and end times, and the method being executed to the log output for each METplotpy run. I approve this request.
Pull Request Testing
Describe testing already performed for these changes:
Remaining plots that needed logging in the METplotpy/metplotpy/plots directory:
skew T
polar plot
scatter plot
NOTE: The MaKEMaKI plot and vertical interpolation plots have code that resides in the METplotpy/metplotpy/contributed directory and will not be addressed in this release.
on host 'seneca', using the mp_analysis_env conda environment (Python 3.1 and packages specified in the requirements.txt file):
skew T plot
polar ice plot
scatter plot
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
log onto 'seneca' and verify logs are present and have content needed by AF STIG:
skew T: /d1/personal/mwin/feature_internal_56_METplotpy_remaining_logging/METplotpy/metplotpy/plots/skew_t/log/tc_diags_skewt.log
polar ice: /d1/personal/mwin/feature_internal_56_METplotpy_remaining_logging/METplotpy/metplotpy/plots/polar_plot/logs/polar_log.txt
scatter: /d1/personal/mwin/feature_internal_56_METplotpy_remaining_logging/METplotpy/test/scatter/scatter_log.txt
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
Do these changes include sufficient testing updates? [NA]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Earliest convenience for beta6 release].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases