Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 420 agg stat bootstrap #426

Merged
merged 34 commits into from
Mar 7, 2025
Merged

Bugfix 420 agg stat bootstrap #426

merged 34 commits into from
Mar 7, 2025

Conversation

bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Feb 25, 2025 •
edited
Loading

Pull Request Testing

  • Describe testing already performed for these changes:

  • Verified new tests are passing

  • Verified plot of AREARAT_FSA_OSA successfully plots

    • Loaded some HRRR data into the Testing group database: mv_met_out on 'dakota'
    • dakota has the bugfix_420_agg_stat_bootstrap feature branch, and 6.0.0 versions of METplotpy, METdataio, and METviewer
    • using the following settings (remove the .txt from the filename)
      plot_20250225_001540.xml.txt

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    • Verify that any other plots of interest are successful

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes]

    If yes, please describe: Code coverage is < 80% (66.7%)

  • Please complete this pull request review by **for the beta2 release **.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

georgemccabe and others added 30 commits November 15, 2024 08:53
@georgemccabe
Per dtcenter/METplus#2336, call custom GHA to trigger METplus use cas…
cde630d 
…e tests when changes are pushed to main_vX.Y and develop branches
@georgemccabe
added missing import (#413)
e4841b8
@jprestop
Adding In Memoriam
9d10ff5
@bikegeek @jprestop
Feature 418 v3.0.0 (#419)
5674017 
* Combined beta release sections under one section

* Updated version, date, author rotation

* Added 'None' to update instructions

* Update release-notes.rst

changing date to 18th since GHA are very slow and unlikely to get release done by today

* Update conf.py

changing date from 17th to 18th, unlikely release will get finished today due to slow GHAs

* Update vulnerabilities.yaml

update version to 1.1.0

* Apply suggestions from code review

Co-authored-by: Julie Prestopnik <[email protected]>

---------

Co-authored-by: Julie Prestopnik <[email protected]>
@bikegeek
Removing. Superfluous since Github does this check
4ad4898
@bikegeek
Merge branch 'main_v3.0' of https://github.com/dtcenter/METcalcpy int…
e084bc5 
…o main_v3.0
@bikegeek
Update agg_stat_bootstrap.py
be32b14 
replace safe.logger with safe_log.logger, to match import
@bikegeek
Update agg_stat_bootstrap.py
99a0072 
fix safe_log.logger to safe_log()
@bikegeek
initialize stat_values list
e75efe9
@bikegeek
return an empty stat_values list in the else
85e2e7d
@bikegeek
fix append to append stat_value, not a list of stat_value
acfdb8c
@bikegeek
move initialization of stat_values list to inside 'if'
fdd7a92
@bikegeek
agg stat bootstrap results from R
f6b6350
@bikegeek
config file for testing agg_stat_bootstrap
79f3c05
@bikegeek
Input data generated by METviewer after SQL query. This matches the i…
4a1681f 
…nput data used by METviewer for calculating the aggregation bootstrap statistics.
@bikegeek
Aggregated bootstrap stats calculated by METcalcpy
3f0f535
@bikegeek
Merge branch 'develop' of https://github.com/dtcenter/METcalcpy into …
0b81924 
…bugfix_420_agg_stat_bootstrap
@bikegeek
Initial work on adding tests for agg_stat_bootstrap for bugfix #420
ae633f3
@bikegeek
Delete test/data/mode/rscript_data/mv_rscript_agg_stat_bootstrap.txt
727fa38 
not the correct data file
@bikegeek
Delete test/data/mode/rscript_data/mv_mode_input_aggregated_python.data
a844221 
file does not belong here
@bikegeek
replacing missing content
12d4e41
@bikegeek
Merge branch 'bugfix_420_agg_stat_bootstrap' of https://github.com/dt…
2bd9785 
…center/METcalcpy into bugfix_420_agg_stat_bootstrap
@bikegeek
Fixed import
1b14efe
@bikegeek
Aggregation statistics calculated via R script in METviewer
b33534c
@bikegeek
Input data used by both R and Python implementations to calculate agg…
6b9c243 
…regation bootstrap statistics
@bikegeek
Config file used by Python implementation of agg_stat_bootstrap.py
79284c4
@bikegeek
Modified cleaning up of temporary files, fixed format of comments
bebe9ab
@bikegeek
Forgot to clean up temp file after second test
826e42a
@bikegeek
Fixed appending to stat_values, should append stat_value and NOT a list
f70aeec
@bikegeek
cleanup was occurring too early, moved outside of testing section
03701d4
@bikegeek bikegeek added this to the METcalcpy-3.1.0 milestone Feb 25, 2025
@bikegeek bikegeek linked an issue Feb 25, 2025 that may be closed by this pull request
Bugfix- agg_stat_bootstrap.py missing initialization of stat_vals list in _calc_stats.py #420
Open
24 tasks
michelleharrold
michelleharrold approved these changes Mar 7, 2025
View reviewed changes
Copy link

@michelleharrold michelleharrold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks/works on my end. I approve!

@bikegeek bikegeek merged commit cbd24bc into develop Mar 7, 2025
6 of 7 checks passed
@bikegeek bikegeek deleted the bugfix_420_agg_stat_bootstrap branch March 7, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelleharrold michelleharrold michelleharrold approved these changes

Assignees

@michelleharrold michelleharrold

Labels
None yet
Projects
METplus-6.1.0 Development
Status: 🏁 Done
Milestone
METcalcpy-3.1.0
Development

Successfully merging this pull request may close these issues.

Bugfix- agg_stat_bootstrap.py missing initialization of stat_vals list in _calc_stats.py
4 participants
@bikegeek @michelleharrold @georgemccabe @jprestop