Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix missing safe_log import #412

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Bugfix missing safe_log import #412

merged 1 commit into from
Nov 14, 2024

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Nov 14, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

Successfully ran UserScript_fcstGFS_obsERA_StratospherePolar use case as described here: dtcenter/METplus#2779 (comment)

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jprestop
Copy link
Collaborator

@georgemccabe Is this change intended to be incorporated into the official coordinated release? I noticed that it was merged in with develop. Looking at the new instructions in this section it says "All remaining development for the upcoming official release occurs on this new ‘main_vX.Y’ branch." However, I believe in a previous Slack message with @JohnHalleyGotway we discussed this, but I can't remember the details. Are we supposed to put changes both in develop and in main_v3.0. Can one of you please clarify?

@jprestop
Copy link
Collaborator

@georgemccabe and @JohnHalleyGotway I just now saw this other PR into main_v3.0, so I'm guessing we are supposed to commit the changes into both main_v3.0 and develop, but would still love confirmation of that.

@bikegeek bikegeek merged commit d5e48f1 into develop Nov 14, 2024
7 checks passed
@bikegeek bikegeek deleted the bugfix_safe_log_import branch November 14, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

3 participants