reset_index is performed on the float value #322

[TatianaBurek]

Pull Request Testing

• Describe testing already performed for these changes:
  Tested on mohawk and locally using attached data
  plot_20230818_180136.agg_stat.info.txt
  plot_20230818_180136.data.agg_stat.txt

REMINDER: change values agg_stat_input and agg_stat_output based on the local configurations

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

  **Run agg_stat.py from the command line:**
  $METCALCPY_BASE/metcalcpy/agg_stat.py plot_20230818_180136.agg_stat.info
  

Verify that the output file you specified in the agg_stat_output setting in the plot_20230818_180136.agg_stat.info (YAML config file) produces the expected output file and the file contains tabular data that is not full of NaN's.

REMINDER: change values agg_stat_input and agg_stat_output based on the local configurations

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

• Do these changes include sufficient testing updates? [Yes or No]

• Will this PR result in changes to the test suite? [Yes or No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[bikegeek]

@TatianaBurek , do you have a screenshot of what the plot is supposed to look like? I'm trying to generate this from the command line with the provided yaml file and I can't seem to get the correct number of plotting settings.

[TatianaBurek]

Attached are the plot and XML files

plot_20230821_174714.xml.txt

[bikegeek]

When generating from the command line, an empty plot is generated and the log file does not indicate any errors. The
plot_20230818_180136.points1 contains all NaN's but the dump points generated by METviewer contains valid numerical values (except for first row).

This is the configuration file used:
plot.yaml.txt

also tried using the originally supplied config file from the Pull Request Testing section (modified to include the plot_ci, plot_disp, series_order, user_legend, series_symbols, and colors):
plot_20230818_180136.agg_stat.yaml.txt

Using this data as input:
plot_20230818_180136.data.agg_stat.txt

With both develop and main_v2.1 versions of METplotpy and the issue_322_reset_index branch of METcalcpy.

Can you take a look and verify if this is also creating an empty line plot?

[TatianaBurek]

The attached files are provided to be used to test pstg_statistics.py using agg_stats.py
Only 2 location parameters in plot_20230818_180136.agg_stat.info.txt should be modified:
agg_stat_input and agg_stat_output
to run :
/METcalcpy/metcalcpy/agg_stat.py plot_20230818_180136.agg_stat.info
The result of the run is the data file. This file should have values different then NA in the stat_value column.
This test doesn't require running METplotpy and creating plots

[bikegeek]

I updated the Pull Request Testing section with these instructions. I wanted to make sure that generating a plot from the command line was unaffected, as the UFS team might be interested in doing this from the command line.

[bikegeek]

ran agg_stat.py from the command line and created a valid output file.