Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature develop update install files #317

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

jprestop
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    Installed METcalcpy on various machines and loaded these modulefiles. They are checked into the repo as a backup and a record.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Ensure all tests pass. Review files.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [When it is convenient, prior to the release; should be quick].

Pull Request Checklist

See the METplus Workflow for details.

  • [No issue] Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • [No issue] After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METcalcpy 2.1.0 milestone Jul 25, 2023
@jprestop jprestop requested a review from bikegeek July 25, 2023 20:13
Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests passing with python 3.10 and corresponding 3rd party packages.

@bikegeek bikegeek merged commit b0345d4 into develop Jul 25, 2023
6 checks passed
@bikegeek bikegeek deleted the feature_develop_update_install_files branch July 25, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants