-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]-corrected the #275 pull request #277
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 95.21% 95.06% -0.16%
==========================================
Files 22 22
Lines 3178 3202 +24
==========================================
+ Hits 3026 3044 +18
- Misses 152 158 +6
Continue to review full report at Codecov.
|
@dswah just check this pull once. All of the tests have passed successfully; so probably good to go. |
Changed the gamma parameter from being default in 1.4 to a user side parameter. #76 should be solved with this. Successfully added gamma and test. |
68fde43
to
f411c35
Compare
@dswah can you merge this change for now? I tried my hand with further development; but seems I am not able to do anything for now. So would like to get this merged. |
Made the following changes:
(1)
type_
changed tooutput
.(2) changed the documentation for return.
(3) added test function to check the shape as well as valueError.