Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace combine with itertools product #253

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

dswah
Copy link
Owner

@dswah dswah commented Jul 16, 2019

for large search-spaces, gridsearch can easily exhaust all available memory before fitting a single model.
This is because the method tries to pre-determine the entire search space in memory.

we could instead use a generator like itertools.product

this fixes #242

TO-DO

  • tests
  • remove all references to pygam.utils.combine

@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #253 into master will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #253      +/-   ##
=========================================
+ Coverage   95.18%   95.2%   +0.01%     
=========================================
  Files          22      22              
  Lines        3178    3169       -9     
=========================================
- Hits         3025    3017       -8     
+ Misses        153     152       -1
Impacted Files Coverage Δ
pygam/utils.py 87.61% <ø> (-0.12%) ⬇️
pygam/pygam.py 94.81% <91.66%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c6c55...df68aac. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid search increasing memory usage
1 participant