Now uses posix_spawn to avoid deadlock

README.md

@@ -1,4 +1,4 @@
-WARNING: This library is unsafe to use until python 3.8 is released due to deadlock issues with fork().
+WARNING: This library requires python 3.8
 
 # Fastprocess
 A fast subprocess library

benchmark/bench

@@ -5,13 +5,17 @@ export PYTHONPATH=$(realpath ${scriptdir}/..)
 printf %"$(tput cols)"s |tr " " "-"
 echo
 echo "10000 spawns with fork and exec..."
-time ${scriptdir}/forktest.py
+time python ${scriptdir}/forktest.py
 printf %"$(tput cols)"s |tr " " "-"
 echo
 echo "10000 spawns with fastprocess..."
-time ${scriptdir}/fptest.py
+time python ${scriptdir}/fptest.py
+printf %"$(tput cols)"s |tr " " "-"
+echo
+echo "10000 spawns with old fastprocess..."
+time python ${scriptdir}/old_fptest.py
 printf %"$(tput cols)"s |tr " " "-"
 echo
 echo "10000 spawns with subprocess..."
-time ${scriptdir}/sptest.py
+time python ${scriptdir}/sptest.py
 printf %"$(tput cols)"s |tr " " "-"

benchmark/old_fptest.py

@@ -0,0 +1,8 @@
+#!/usr/bin/python3
+
+from fastprocess import FastProcess, OldFastProcess
+
+procs = []
+
+for i in range(10000):
+    procs.append(OldFastProcess(['echo', 'hello', 'world'], stdout=open('/dev/null', 'w')))

fastprocess/__init__.py

@@ -1 +1 @@
-from fastprocess.fastprocess import FastProcess
+from fastprocess.fastprocess import FastProcess, OldFastProcess

fastprocess/fastprocess.py

@@ -2,6 +2,30 @@
 import signal
 
 class FastProcess:
+    def __init__(self, cmd, stdin=None, stdout=None, stderr=None, env=None):
+        file_actions = []
+        if stdin:
+            file_actions.append((os.POSIX_SPAWN_DUP2, stdin.fileno(), 0))
+        if stdout:
+            file_actions.append((os.POSIX_SPAWN_DUP2, stdout.fileno(), 1))
+        if stderr:
+            file_actions.append((os.POSIX_SPAWN_DUP2, stderr.fileno(), 2))
+        self.pid = os.posix_spawnp(cmd[0], cmd, env if env else os.environ, file_actions=file_actions)
+
+    def __del__(self):
+        os.kill(self.pid, signal.SIGTERM)
+
+    def terminate(self):
+        os.kill(self.pid, signal.SIGTERM)
+
+    def signal(self, sig):
+        os.kill(self.pid, sig)
+
+    def wait(self):
+        return os.WEXITSTATUS(os.waitpid(self.pid, 0)[1])
+
+
+class OldFastProcess:
     def __init__(self, cmd, stdin=None, stdout=None, stderr=None):
         self.pid = os.fork()
         if self.pid == 0:

setup.py

@@ -3,13 +3,14 @@
 
 setup(
     name='fastprocess',
-    version='0.1.0',
+    version='1.0.0',
     author='Dylan Stephano-Shachter',
     author_email='[email protected]',
     description=('A fast subprocess library'),
     license='LGPL',
     url='https://github.com/dstathis/fastprocess',
     packages=['fastprocess'],
+    python_requires='>=3.8',
     long_description=open(
         os.path.join(os.path.dirname(os.path.abspath(__file__)), 'README.md')
     ).read(),