Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cyclical features #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cyclical features #161

wants to merge 1 commit into from

Conversation

silil
Copy link
Collaborator

@silil silil commented Jun 30, 2019

  • Sine and Cosine transformation for cyclical features

Maren-Eckhoff
Maren-Eckhoff requested changes Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@Maren-Eckhoff Maren-Eckhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, the main change is that you'd like to include some images, correct? I would suggest to force these images into the git repository.

@silil silil requested a review from Maren-Eckhoff July 4, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanounanue nanounanue Awaiting requested review from nanounanue

@rayidghani rayidghani Awaiting requested review from rayidghani

@Maren-Eckhoff Maren-Eckhoff Awaiting requested review from Maren-Eckhoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silil @Maren-Eckhoff