-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classifiers that respect categoricals #34
base: master
Are you sure you want to change the base?
Conversation
Creates a new pair of classifiers, CatInATree and CatInAForest, that respect categoricals when randomly sampling features.
remove the min_impurity_decrease parameter from DecisionTreeClassifier call to conform to sklearn 0.18
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 91.23% 91.23% +<.01%
==========================================
Files 13 13
Lines 844 993 +149
==========================================
+ Hits 770 906 +136
- Misses 74 87 +13
Continue to review full report at Codecov.
|
for non-categorical columns where imputation was performed, ensure the flag and underlying column always come together for models that respect categoricals (in the future, we may want to consider passing these separately but for the purposes here we just add them in with the categoricals)
@hakoenig made the good point that with the new imputation branch we should also ensure that imputed flags always get picked up along with their underlying columns, so pushed a quick change that adds those groupings in here as well. |
This PR creates a new pair of classifiers,
CatInATree
andCatInAForest
, that respect categoricals when randomly sampling features. A few notes:_train
method ofModelTrainer
to pass these detected column groupings.