Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small adjustment in order to make yarn-completion.bash compatible to zsh #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayefem
Copy link

@jayefem jayefem commented Dec 19, 2023

Works for me on zsh 5.8.1 (x86_64-ubuntu-linux-gnu) when adding the following to ~/.zshrc:

source yarn-completion.bash

" RETURN

shopt -s extglob
if [[ "$SHELL" != "/bin/zsh" && "$SHELL" != "/usr/bin/zsh" ]]; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if zsh is installed in a non-standard path? Like if installed by homebrew or something? Is there a more reliable way of determining this?

Or perhaps instead of making this a check of the negative ("this shell is not zsh"), maybe it would be better to make this a check of the affirmative ("this shell is bash").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants