chore(bors): merge pull request openebs#714

714: feat(eventing): state change events for node r=datacore-vvarakantham a=datacore-vvarakantham

Added node state change events.

Co-authored-by: Vandana Varakantham <[email protected]>

control-plane/agents/src/bin/core/node/wrapper.rs

@@ -14,7 +14,8 @@ use crate::{
     pool::wrapper::PoolWrapper,
     NumRebuilds,
 };
-use agents::errors::SvcError;
+use agents::{errors::SvcError, eventing::EventWithMeta};
+use events_api::event::{EventAction, EventCategory, EventMessage, EventMeta, EventSource};
 use grpc::operations::snapshot::SnapshotInfo;
 use stor_port::{
     transport_api::{Message, MessageId, ResourceKind},
@@ -409,6 +410,15 @@ impl NodeWrapper {
             }
 
             self.node_state.status = next;
+            self.event(
+                EventAction::StateChange,
+                event_meta(
+                    self.id().to_string(),
+                    previous.to_string(),
+                    self.node_state.status.to_string(),
+                ),
+            )
+            .generate();
             if self.node_state.status == NodeStatus::Unknown {
                 self.watchdog_mut().disarm()
             }
@@ -853,6 +863,24 @@ impl NodeWrapper {
     }
 }
 
+// State change event for node
+impl EventWithMeta for NodeWrapper {
+    fn event(&self, event_action: EventAction, meta: EventMeta) -> EventMessage {
+        EventMessage {
+            category: EventCategory::Node as i32,
+            action: event_action as i32,
+            target: self.id().to_string(),
+            metadata: Some(meta),
+        }
+    }
+}
+
+// Get event meta data for node state change event
+fn event_meta(nodeid: String, previous: String, next: String) -> EventMeta {
+    let event_source = EventSource::new(nodeid).with_state_change_data(previous, next);
+    EventMeta::from_source(event_source)
+}
+
 /// Fetches node state from the dataplane.
 #[derive(Debug, Clone)]
 pub(crate) struct NodeStateFetcher {

control-plane/agents/src/bin/ha/cluster/switchover.rs

@@ -1,5 +1,5 @@
 use crate::{core_grpc, etcd::EtcdStore, nodes::NodeList};
-use agents::Event;
+use agents::eventing::Event;
 use anyhow::anyhow;
 use chrono::Utc;
 use events_api::event::{

control-plane/agents/src/bin/ha/node/detector.rs

@@ -3,7 +3,7 @@ use crate::{
     reporter::PathReporter,
     Cli,
 };
-use agents::Event;
+use agents::eventing::Event;
 use events_api::event::{EventAction, EventCategory, EventMessage, EventMeta, EventSource};
 use nvmeadm::nvmf_subsystem::Subsystem;
 use std::{collections::HashMap, convert::From, rc::Rc, sync::Arc};

control-plane/agents/src/bin/ha/node/server.rs

@@ -6,7 +6,7 @@ use crate::{
 };
 use agents::{
     errors::{SvcError, SvcError::SubsystemNotFound},
-    EventWithMeta,
+    eventing::EventWithMeta,
 };
 use events_api::event::{EventAction, EventCategory, EventMessage, EventMeta, EventSource};
 use grpc::{

control-plane/agents/src/eventing/mod.rs

@@ -0,0 +1,19 @@
+use events_api::event::{EventAction, EventMessage, EventMeta};
+
+/// Event trait definition for creating events.
+pub trait Event {
+    /// Create event message.
+    fn event(&self, event_action: EventAction) -> EventMessage;
+}
+
+/// Event trait definition for creating events and adding meta data.
+pub trait EventWithMeta {
+    /// Create event message with meta data.
+    fn event(&self, action: EventAction, meta: EventMeta) -> EventMessage;
+}
+
+/// A trait for generating event metadata.
+pub trait EventMetaGen {
+    /// Create metadata to be included with the event.
+    fn meta(&self) -> EventMeta;
+}

control-plane/agents/src/lib.rs

@@ -5,7 +5,6 @@
 //! It's meant to facilitate the creation of agents with a helper builder to
 //! subscribe handlers for different message identifiers.
 
-use events_api::event::{EventAction, EventMessage, EventMeta};
 use futures::Future;
 use grpc::tracing::OpenTelServer;
 use snafu::Snafu;
@@ -14,6 +13,8 @@ use std::{net::SocketAddr, sync::Arc};
 use stor_port::transport_api::ErrorChain;
 
 mod common;
+/// Event definitions.
+pub mod eventing;
 
 /// Agent level errors.
 pub use common::errors;
@@ -172,15 +173,3 @@ impl<L> Service<L> {
         configure(self).await
     }
 }
-
-/// Event trait definition for creating events.
-pub trait Event {
-    /// Create event message.
-    fn event(&self, event_action: EventAction) -> EventMessage;
-}
-
-/// Event trait definition for creating events and adding meta data.
-pub trait EventWithMeta {
-    /// Create event message with meta data.
-    fn event(&self, action: EventAction, meta: EventMeta) -> EventMessage;
-}