Desafío Semana 1 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablomdd
reviewed
May 28, 2021
pablomdd
requested changes
May 28, 2021
There was a problem hiding this comment.
Muy buen código! Puedo ver que tienes ya conocimientos de CSS :)
Te dejé un review sobre una clases que repites y se puede mejorar. El comentario va a que usamos clases para reutilizar código y digamos, en esa parte las estas usando como partes individuales y repitiendo esos estilos.
El resto se ve todo muy bien!
challenges/week1/Semana1/main.css
Outdated
| border:rgba(36,36,44,255) 5px double; | ||
| border-radius: 20px | ||
| } | ||
| .Blogr_foot{ |
There was a problem hiding this comment.
Como pequeña mejora: Los nombres de cualquier cosa en CSS van todo en minusculas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perdón por la tardanza, no tengo experiencia en github y se me complicó un poco ):
Challenge